go-ios icon indicating copy to clipboard operation
go-ios copied to clipboard

Remove panic() from the codebase

Open danielpaulus opened this issue 3 years ago • 3 comments

In a few places I used panic() back when I first wrote the code. I have come to the conclusion that panic and log.Fatal should not be used normally in library code. I want to search the code base for panic() and replace it with returning an error. Here is a good example for a small PR: https://github.com/danielpaulus/go-ios/blob/0fe0fcf2f1fd61d3275d36d1ce5e7a711e6c51c6/ios/nskeyedarchiver/archiver.go#L76

danielpaulus avatar Oct 08 '22 07:10 danielpaulus

would be glad to take this up :)

snapdgn avatar Oct 08 '22 09:10 snapdgn

@danielpaulus is this still open to be picked?

grokkos avatar Nov 06 '22 18:11 grokkos

yeb. @grokkos still open.

danielpaulus avatar Nov 07 '22 07:11 danielpaulus