bbs-fw icon indicating copy to clipboard operation
bbs-fw copied to clipboard

Feature/apply pretension

Open EigenMania opened this issue 1 year ago • 7 comments

Pretension feature, since many users keep asking for it. When enabled, a constant current of 1% is applied when above a configured road-speed. Speed sensor necessary to use the feature. Can be enabled and disabled from the GUI.

EigenMania avatar Dec 03 '24 15:12 EigenMania

Thank you! Looks nice on a first check, I want to get this merged. But this PR has a lot of commits and merge commits in history. Any chance you could rebase your branch on my master and the submit your changes as a single commit instead?

danielnilsson9 avatar Dec 03 '24 19:12 danielnilsson9

I also realized (after submitting the PR) that I should also update some of the GUI figures to show the new fields. So I'll make these updates and then re-submit the PR and squash the commits.

EigenMania avatar Dec 03 '24 21:12 EigenMania

Rebased and squashed :)

EigenMania avatar Dec 10 '24 16:12 EigenMania

Thanks for doing this gentlemen! 😊 Can't wait to update! 😁

DrMouse84 avatar Dec 22 '24 15:12 DrMouse84

Is there already a finished version available for download?

Larswagner1987 avatar Dec 22 '24 18:12 Larswagner1987

Fixed some issues with line endings, now the diff should be easier to review. Some files (like SystemView.xaml) use the Unix standard with LF, while most others follow the DOS standard with CRLF, and this caused a bit of a mess at some point.

EigenMania avatar Jan 16 '25 10:01 EigenMania

Hello gentlemen, any updates yet?

DrMouse84 avatar Feb 15 '25 11:02 DrMouse84

This looks good, thanks for the PR!

danielnilsson9 avatar Mar 03 '25 09:03 danielnilsson9