bbs-fw icon indicating copy to clipboard operation
bbs-fw copied to clipboard

modifications to lvc rampdown computations

Open EigenMania opened this issue 1 year ago • 1 comments

I'm proposing a very slight modification for how the LVC rampdown computations are performed. I changed LVC_RAMP_DOWN_OFFSET_PERCENT to reflect the battery percentage when LVC rampdown starts, and the LVC rampdown ends when 0% battery is reached (the padded value), thus protecting the battery a bit more from discharge at configured LVC (and lining up with the displayed battery percentage).

Also moved the defines from battery.c into fwconfig.h and added some more detailed comments / examples for the battery math.

EigenMania avatar Dec 24 '23 11:12 EigenMania

Looks good to me. Ship it!

timothymiller avatar Jun 15 '24 03:06 timothymiller

Seems like a reasonable change, thanks!

danielnilsson9 avatar Aug 07 '24 10:08 danielnilsson9