Fabric icon indicating copy to clipboard operation
Fabric copied to clipboard

Published 20 hours ago • verified publisher icon danielmiessler

dockerised or containerised fabric

Open fahadshery opened this issue 1 year ago • 1 comments

What this Pull Request (PR) does

I added the docker folder with the required DockerFile etc. to containerise fabric application.

Related issues

closes #327.

fahadshery avatar Aug 20 '24 10:08 fahadshery

@xssdoctor what do you think on this one?

danielmiessler avatar Aug 20 '24 21:08 danielmiessler

+1 on this. This allows me to run this without installing a bunch of stuff on my computer

bijeebuss avatar Aug 27 '24 16:08 bijeebuss

actually apparently I can just do this and it saves the install of fabic

alias gocontainer='docker run -it --pull always --rm -v $HOME:/root -v $(pwd):/go -w /go golang:latest'

bijeebuss avatar Aug 27 '24 17:08 bijeebuss

Thank you for the PR.

Please also check those 3 points.

  1. Docker image for production Your image will work for sure. The best practice for production is to use small Docker images that contain only the application itself, without any unnecessary dependencies. To run Fabric, we don't need the Go development environment; we only need the binary. To create such an image, a multi-stage Dockerfile is typically used. Please check the example here and adapt the Dockerfile accordingly.

  1. Please clean up docker-compose file. Remove all commented out lines and the traefic network.

  2. Please add Github Action to build and publish Docker image to Github Registry, see e.g. here

eugeis avatar Aug 29 '24 18:08 eugeis

Love it.

danielmiessler avatar Sep 08 '24 01:09 danielmiessler

  1. Please add Github Action to build and publish Docker image to Github Registry, see e.g. here

Hi,

Thanks for the suggestions. I can look into point 1 and 2. But for point 3 I think it's better if @danielmiessler would publish the image on dockerhub himself. it would also confirm that the docker image is officially supported.

fahadshery avatar Sep 08 '24 14:09 fahadshery

Someone help me install Fabric AI in a docker on Unraid? I don't know how to build this docker in Unraid because it asks for the image path.

brauliodiasribeiro avatar Sep 08 '24 18:09 brauliodiasribeiro

Someone help me install Fabric AI in a docker on Unraid? I don't know how to build this docker in Unraid because it asks for the image path.

It would be best to learn to build the image yourself. Unless I am mistaken, based on reading this PR, you still need to build the image for yourself because the choice to automate the build and upload to GHCR was pushed back on the core dev, and then there was some confusing statement about using Docker Hub instead of the proposed GHCR.

In summary, there's a missing step and more work needs to be done and there is some confusion between two people as to where to upload the image after it's built.

yousecjoe avatar Sep 14 '24 03:09 yousecjoe

Someone help me install Fabric AI in a docker on Unraid? I don't know how to build this docker in Unraid because it asks for the image path.

It would be best to learn to build the image yourself. Unless I am mistaken, based on reading this PR, you still need to build the image for yourself because the choice to automate the build and upload to GHCR was pushed back on the core dev, and then there was some confusing statement about using Docker Hub instead of the proposed GHCR.

In summary, there's a missing step and more work needs to be done and there is some confusion between two people as to where to upload the image after it's built.

I don't have the knowledge to do this. I'll study more and follow the forum. Thanks for your help

brauliodiasribeiro avatar Sep 14 '24 10:09 brauliodiasribeiro