graphitesend icon indicating copy to clipboard operation
graphitesend copied to clipboard

Allow python3 encode/decodes

Open daubers opened this issue 8 years ago • 3 comments

This was stopping me from using this on a py3 only system. A simple check to see if the message is a python 3 byte object and then handle it appropriately

daubers avatar Dec 19 '16 14:12 daubers

Coverage Status

Coverage increased (+0.09%) to 93.426% when pulling bbc03312e1f793013eadd9da9996bbd1dcfead8a on daubers:py3encodes into 262852575f6bc47cb039c1ddebd47a1c62fa4775 on daniellawrence:master.

coveralls avatar Dec 19 '16 14:12 coveralls

@daubers What was the error you had with the current implementation ? We have a test suite for Python 3 so I'm a bit surprised that it doesn't work for you, even on py3 only systems

Shir0kamii avatar Dec 26 '16 22:12 Shir0kamii

Coverage Status

Coverage increased (+0.09%) to 93.426% when pulling 0a4fb004add4ae74a2df25b2d86c5a2fae7f8bf5 on daubers:py3encodes into 6f84c56ad4e7594cf36b0c3d4aeaa86b4dd3ef06 on daniellawrence:master.

coveralls avatar Jan 06 '17 21:01 coveralls