Daniel Jacobs

Results 69 comments of Daniel Jacobs

PR #7167 does what https://github.com/mdn/yari/issues/5041#issuecomment-1248598636 describes. The question remains though on whether this change makes sense or changes should be made in BCD itself instead/as well.

While I don't think they're large enough to matter too much, and most are technically territories, some with no permanent residents, aren't the following ISO defined country codes also missing:...

This is subjective, as you said. At work, my display is 1920x1200 and the Ruffle homepage is the perfect height for that size (see screenshot), but I acknowledge my monitor...

Well, seeing this get no attention, hopefully most users of this action can have their use cases covered with https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter. For reference, for Ruffle that was done in this PR:...

This was the original search shortcut. Ctrl-K was added as a secondary shortcut in #5962, and it was made not to trigger on Ctrl-Shift-K in #7067. Note, the same shortcuts...

Also note, on any Google search page (e.g. https://www.google.com/search?q=test), slash focuses the search field, so this isn't entirely uncommon.

It's also worth noting, Ctrl-K itself is overriding a Firefox shortcut too. On websites where Ctrl-K does not have any other function, it searches your default search engine via the...

On websites that override Ctrl-K, you can accomplish the same thing with Ctrl-L followed by Ctrl-K, but that's increasing the number of shortcuts to two instead of one.

I think `trailingSlash: true` would mostly be fine, but the issue is it would break https://ruffle.rs/avm2.html. It would also break https://ruffle.rs/downloads.html etc, but I'm not so worried about those pages...