Daniel Henry-Mantilla
Daniel Henry-Mantilla
The zeroing part in general looks weird to me, justification-wise. I think the problem is more general than just zeroing structs on `Drop`; it's more about carefully crafting the right...
I have mixed feelings about this: to me not trusting the FFI language to overflow _w.r.t_ to the given pointer is pushing things too far. Or to put it in...
> a less error-prone catch_unwind API. FWIW, the `catch_unwind` API problem is kind of already paliated with https://github.com/rust-lang/rust/pull/99032. Then, with @LegionMammal978's proposal, and potentially with also something like [`::unwind_safe`](https://docs.rs/unwind_safe/0.1.0/unwind_safe/index.html)'s API,...
@seanpianka I can't speak of this crate, but what you can do is feature-gat that `include_str!` of yours: ```rust #![cfg_attr(feature = "better-docs", cfg_attr(all(), doc = include_str!("../README.md")), )] ``` with some...
I'm guessing this is the cause of a panic at the following line: https://github.com/hawkw/sharded-slab/blob/81c1c3fa846c364d9fcd6a7dde7841a7ce80f14b/src/shard.rs#L297 ? If anything, replacing that `[idx]` with `.get(idx).expect("too many threads")` would already be quite helpful when...
> cargo-geiger shows 10 unsafe expressions but I can't see them in actix git, might be a bug I've run it and for me it shows them for `cargo-geiger 0.2.0`,...
Agreed. I haven't set up `cargo crev` for myself yet, but I know I would greatly appreciate having a list of ids, especially for the people in safety dance.
@DoumanAsh the problem does not lie in writing to a `&mut [u8]` being UB, but in the `Read` trait requiring a `&mut [u8]` to write to it. `Read` ought to...
The line https://github.com/gamozolabs/fzero_fuzzer/blob/6fe91bcd87af1db71472f4b549e66ea273811576/src/main.rs#L302 can wrap and overflow, especially on `release` with its `overflow-checks = false` default setting, which means that the `.reserve()` may not happen even when necessary, which makes...
FWIW, it could use `str::from_utf8_unchecked`, which would already be a bit less `unsafe` than a `transmute` (one oughtn not to transmute `repr(Rust)` entities, even just the wide-pointer ones). Also, there...