Daniel Han

Results 781 comments of Daniel Han

Oh yep! :) Thanks for the request - I'll take a look at their code base :)

@t-vi Oh cool thanks! Did not notice the changes in Triton v3! Let me install the dev branch and check it out :)

@thedarkzeno Sorry on the delay!! Interesting on Yarn! I think I saw this metholodgy floating around, but I've never gotten round to them - I'm not an expert in Yarn,...

Oh we do have a Kaggle notebook! https://www.kaggle.com/code/danielhanchen/kaggle-mistral-7b-unsloth-notebook

@HirCoir Oh yes! Sorry I will fix Kaggle! Thanks so much on the bug report as well!

@HirCoir Fixed! Sorry on the delay! https://www.kaggle.com/code/danielhanchen/kaggle-mistral-7b-unsloth-notebook should have new Kaggle install instructions!

@charlesCXK Oh I think you'll have to add `modules_to_save` ie https://github.com/unslothai/unsloth/wiki#finetuning-the-lm_head-and-embed_tokens-matrices I haven't yet fixed some parts, so hopefully I'll fix this by today! Sorry on the delay!

@charlesCXK Oh thanks!! So sorry again on the issue! I'll take a look a your PR - thanks so much again!

@burgerbee The EOS token seems correct no? ![image](https://github.com/unslothai/unsloth/assets/23090290/3cdeb6b0-c72b-4c43-85b8-be09fc9f73a5) Also the generation config: ![image](https://github.com/unslothai/unsloth/assets/23090290/9e65b99a-c503-4968-aee9-332f2af359ac) I did update the models, so you might have to re download them