mkdocs-jupyter icon indicating copy to clipboard operation
mkdocs-jupyter copied to clipboard

Latest release on PyPi has no associated `.tar.gz`

Open cwognum opened this issue 1 year ago • 5 comments
trafficstars

Hi @danielfrg, the conda-forge release of v0.24.7 is failing, see https://github.com/conda-forge/mkdocs-jupyter-feedstock/pull/29. This seems to be happening because the latest mkdocs release on PyPi lacks a .tar.gz Source Distribution. Earlier versions do have such a source distribution.

This is causing downstream errors because mkdocs-jupyter <0.24.7 is incompatible with mkdocs >=1.6.0. A simple workaround is to install the latest version of mkdocs-jupyter over pip, but it would be great if this can be fixed soon.

Screenshot

image

cwognum avatar Apr 30 '24 19:04 cwognum

It was accidental. I do use rye like you mentioned. I think hatch stuff is just there from the old way of building.

I should update the scripts to generate the .tar.gz too.

I'll try to take a look when I get some time.

danielfrg avatar May 07 '24 17:05 danielfrg

Sorry for deleting my comment, after posting it I realized my question didn't make sense and was hoping to update it before you saw it! :sweat_smile:

The question I intended to ask: Could you explain if this was intentional or accidental (e.g. you forgot to run pnpm run build)? If the .tar.gz Source Distribution will by missing from PyPi from now on, I will look into updating the conda-forge release process to generate the missing files. If I run the steps in RELEASE.md locally, the .tar.gz is generated as expected! I'm not sure why it's missing from PyPi for 0.24.7?

For reference: The deleted comment

@danielfrg Could you explain if this was intentional or accidental (e.g. you forgot to run pnpm run build)? If the .tar.gz Source Distribution will by missing from PyPi from now on, I will look into updating the conda-forge release process to generate the missing files. It seems we would just need to run vite build by running the build script of package.json (with pnpm or the like).

In case of the latter, it would be helpful to better understand how the package is released. Looking into RELEASE.md and Taskfile.yml, it seems you use rye to build and release the Python package, paired with pnpm (& vite) to build the web assets. How does hatch fit in?

cwognum avatar May 07 '24 18:05 cwognum

that was my undestanding as well, that the tar.gz should be generated, maybe its then rye didnt upload it for some reason

danielfrg avatar May 08 '24 13:05 danielfrg

Hey @danielfrg, any update on the above?

cwognum avatar May 23 '24 15:05 cwognum

Hey @danielfrg, any update on the above?

@danielfrg, I'm interested in getting this sorted out too. Thank you so much for your work on this extension!

chuckwondo avatar Jun 03 '24 13:06 chuckwondo

Fixed on the latest version.

danielfrg avatar Jul 02 '24 22:07 danielfrg

Thanks @danielfrg !

Fixed for conda-forge with https://github.com/conda-forge/mkdocs-jupyter-feedstock/pull/35 as well.

cwognum avatar Jul 03 '24 15:07 cwognum