loggerpro icon indicating copy to clipboard operation
loggerpro copied to clipboard

Published 20 hours ago • verified publisher icon danieleteti

PR for https://github.com/danieleteti/loggerpro/issues/92

Open fastbike opened this issue 1 year ago • 4 comments
trafficstars

PR for refactoring for Issue #92

Re factored file rotation:

  • moved functionality into own helper object with base interface to define behaviour
  • provide two concrete implementations:
    • Rotate by file count
    • Rotate by file date
  • Tidied up the LogFileFormat checks to use an enumeration
  • Moved file maintenance methods (Delete / Rename) to the helper objects

fastbike avatar Aug 06 '24 02:08 fastbike

Added code to address the issue mentioned in https://github.com/danieleteti/loggerpro/issues/47

fastbike avatar Aug 12 '24 22:08 fastbike

Hi @fastbike , could you adapt your PR with the current code base in the v2 branch?

danieleteti avatar Mar 20 '25 15:03 danieleteti

Hi @fastbike , could you adapt your PR with the current code base in the v2 branch?

That's good timing as I'm just updating our code base today to use DMVC Magnesium, so will look at the dependencies while I'm doing that

fastbike avatar Mar 20 '25 19:03 fastbike

Great!

danieleteti avatar Mar 20 '25 20:03 danieleteti

What am I doing wrong?

You are hijacking a discussion with a totally unrelated topic. Please remove it here and create an own issue with your question.

luebbe avatar Oct 09 '25 09:10 luebbe