Daniel Compton

Make highlighting distinguish between protocols and functions

1

When scrolling through the docs at http://andrewmcveigh.github.io/cljs-time/latest/cljs-time.core.html, I noticed that the sidebar flickers when you are scrolling around at the point of `period`. It looks like this is because Codox...

Add link to file in heading

2

When generating source, you can add links to the individual functions, but there isn't a top level link to go to the file itself. It would occasionally be handy to...

Responsive theme for Codox

3

Would you be interested in Codox having a responsive theme? On the iPhone, api docs are quite hard to read.

I was looking at the example docs and saw examples like `.foo, .foo.bar, .foo?`. That was all in one code block so I thought together it was a valid jq...

Migrate hiccup.page (and others?) to hiccup2 namespace?

12

I'm adopting hiccup2 on a project, but noticed that hiccup.page doesn't have a hiccup2 version. This means as far as I can tell, the only way to get the `html5`...

Escaping attributes, css, javascript, url's

1

The Owasp [XSS cheatsheet](https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet) talks about escaping html, attributes, css, javascript, and URLs. It seems like Hiccup does html and url escaping, but doesn't provide functions for escaping the others....

Escape / ?

1

OWASP recommend escaping forward slashes as well. Would you be happy to take a PR for this? https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content

Document how to use :consumer to coerce request bodies

2

The Yada docs don't discuss `:consumer`. This is an invaluable feature when you need to get the raw body of the request. One use-case for this is when you want...

HEAD requests throw exceptions

1

I've noticed that HEAD requests seem to be throwing unconsumed deferred errors. 16:41:24.770 WARN manifold.deferred - unconsumed deferred in error state, make sure you're using `catch`. java.lang.Thread.run Thread.java: 745 java.util.concurrent.ThreadPoolExecutor$Worker.run...

:exists? property doesn't return a 404 for HEAD request but does for GET

2

It's quite possible I'm misunderstanding yada or the HTTP spec, but I was surprised by this behaviour: ```clj (deftest put-missing-test (let [res (resource {:id :put-test :properties {:exists? false} :methods {:get...