Dani Donisa

Results 54 comments of Dani Donisa

> > Maybe we need to use the word "Toggle" in the button so everybody knows it flips the state, whatever the state is? > > Toggling is generally a...

> Some day, this should probably be followed up by https://trello.com/c/hqkiRR1d Yes! Please!

For me, we can rollback [this commit](https://github.com/openSUSE/open-build-service/pull/16183/commits/08fe297361083db3aa734008105242b3810f8289), ternaries are harder to read.

It's strictly needed to do this refactoring for the move to STI based notifications? I believe we may benefit from having the component specs in this case, we have those...

> It's no required, but it's the way I found to get rid of the ViewComponent on a previous PR, before the final refactoring, which will remove the component anyway....

I think all this BsRequestPermissionCheck should be a policy

Apart from the dates missing, the rest is good to go

> I would like to work on this issue. Hey! Feel free to work on this and don't hesitate to tell us if you're stuck with something.

![](https://github.trello.services/images/mini-trello-icon.png) [Data too long for column request_payload (M)](https://trello.com/c/oaqQLSbO/1862-data-too-long-for-column-requestpayload-m)