elixir-web-push-encryption icon indicating copy to clipboard operation
elixir-web-push-encryption copied to clipboard

Published 20 hours ago • verified publisher icon danhper

Incorrect assumption about FCM endpoint

Open arjan opened this issue 6 years ago • 4 comments

This code asserts that an auth key (GCM sender ID) is required when a push subscription is sent from FCM. However, this is not true because FCM fully implements VAPID, as can be read here: "With VAPID you no longer need to sign up for an account with GCM".

My suggestion therefore is to remove this function clause altogether, as well as this part.

arjan avatar Aug 16 '19 10:08 arjan

Hi, thanks for reporting the issue. I suppose that was the situation when I first implemented this library but if it not required anymore this should indeed be fixed. It would be great if you had the time to send a PR with the changes you suggested. Thanks a lot.

danhper avatar Aug 16 '19 14:08 danhper

Yes, only, this will effectively reverse #13 so I am curious why @splagemann fixed this in the first place...

arjan avatar Aug 16 '19 16:08 arjan

I'm pretty sure that I had issues without an auth key. But I can check that again and I'm happy to have that removed.

splagemann avatar Aug 17 '19 15:08 splagemann

I had issues with an auth key :-) Anyway I think it's possible to support both code paths. Could you check whether the auth key path works for you?

arjan avatar Aug 19 '19 07:08 arjan

What is the status of this issue?

drobban avatar Feb 19 '21 10:02 drobban