react-infinite-scroller
react-infinite-scroller copied to clipboard
Any want to move to typescript, webpack, etc.?
I noticed a few things in the code base and was curious if you would be interested in PR's that:
- Migrate from gulp to webpack
- Migrate from prop-types to typescript
- Added prettier support for other files (html, json, etc)
- Renovatebot to maintain dependency freshness
- Migrate from mocha/nyc to jest
And any other infrastructure or updates you were interested in making. I'd be happy to contribute (I think this is an awesome project) just want to make sure some of these are goals before getting started.
I'm working on new things on the v2 branch. All of these ideas would be very welcome on there. Thank you!
Sorry for the delay, was busy with actual work :-) https://github.com/CassetteRocks/react-infinite-scroller/pull/191
Moved to typescript, webpack and jest. As I was changing the code I did notice some oddities that may want to be looked into before releasing v2 such as dropping some old properties (loaderkey for example) and other things.
Also, give this code a sanity check, I couldn't build the demo site on my local machine (several dependences seem to be expected as global... I have no global packages ;-)).
I think a larger discussion around the example page could be had... particularly moving it out of this repository into it's own npm package. The doc site could load it via unpkg.com similar to this page https://github.com/snowcoders/react-ui-base/blob/master/docs/index.html which I found simplifies updates quite nicely.
Feel free to edit the branch and diff as you wish, I'll be off and on for a while (end of the year pushes) so I'm not sure how much actual code I'd get to write but should be available for chats.
Nice work!
FYI if you get this merged in I may have more time to work on it this weekend.
dislike typescript...