Don't pull the icons from the Font-Awesome master during install

[tholewebgods]

The icons.json is downloaded using a package.json install script. The source is the master of the Font-Awesome project repository.

This way the installation is not reproducible and controllable. The plugin should either rely font-awesome as a peer dependency and use the _variables.scss from the node_modules location or the developer should be able to pass the _variables.scss path via the config.

The plugin might cache the icon.json based on the modification timestamp.

[trxcllnt]

@dan-gamble looks like they moved the files around in git for font-awesome 5.0, and now this is failing our CI builds:

npm ERR! execute Error: Command failed: npm install
npm ERR! execute /app/node_modules/postcss-font-awesome/generateIconConfig.js:17
npm ERR! execute         throw new Error(
npm ERR! execute         ^
npm ERR! execute 
npm ERR! execute Error: Failed to fetch variables from Github, got HTTP 404
npm ERR! execute     at ClientRequest.<anonymous> (/app/node_modules/postcss-font-awesome/generateIconConfig.js:17:15)
npm ERR! execute     at Object.onceWrapper (events.js:254:19)
npm ERR! execute     at ClientRequest.emit (events.js:159:13)
npm ERR! execute     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:550:21)
npm ERR! execute     at HTTPParser.parserOnHeadersComplete (_http_common.js:117:23)
npm ERR! execute     at TLSSocket.socketOnData (_http_client.js:439:20)
npm ERR! execute     at TLSSocket.emit (events.js:159:13)
npm ERR! execute     at addChunk (_stream_readable.js:265:12)
npm ERR! execute     at readableAddChunk (_stream_readable.js:252:11)
npm ERR! execute     at TLSSocket.Readable.push (_stream_readable.js:209:10)

[danielsamuels]

Yeah, we're seeing the same thing:

Error: Failed to fetch variables from Github, got HTTP 404

error /home/ubuntu/crewseekers/node_modules/postcss-font-awesome: Command failed.
Exit code: 1
Command: node ./generateIconConfig.js
Arguments: 
Directory: /home/ubuntu/crewseekers/node_modules/postcss-font-awesome
Output:
/home/ubuntu/crewseekers/node_modules/postcss-font-awesome/generateIconConfig.js:17
        throw new Error(
        ^

Error: Failed to fetch variables from Github, got HTTP 404
    at ClientRequest.<anonymous> (/home/ubuntu/crewseekers/node_modules/postcss-font-awesome/generateIconConfig.js:17:15)
    at ClientRequest.g (events.js:291:16)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:474:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)
    at TLSSocket.socketOnData (_http_client.js:363:20)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

yarn returned exit code 1

[dan-gamble]

I'll try and get this rectified before the end of the day guys.

[dan-gamble]

I've just pushed 0.4.0. Does this rectify the issue for you?

[boazblake]

yes that fixed it for me thank you

[dan-gamble]

Awesome, will leave this open for another ~24 hours or so then close it if it fixes for all.

[NickSpinosa]

this fixed the CI error for me, but icons aren't being displayed after the version bump

[dan-gamble]

I'll see if i can give that a look at over the weekend. I've not used this plugin for a while now so unsure on it's current state sorry.

[petejohansonxo]

This is back, now that FA renamed/moved the branch name.