subman API

[ksedgwic]

[ksedgwic]

I bet we could make the SubEndpoint a scoped object which automatically unsubscribes when it is dropped ...

[ksedgwic]

I'm missing the outer flow on outbox ... is this right?:

1. user clicks to view thread
2. we one-time fetch k:10002 for author and determine authors relays
3. we subscribe to the thread with SubConstraint::OutboxRelays(author_relays)
4. SubMgr evaluates relays, possibly changes current set
5. user disposes of thread view, we remove subscription (and reevaluate relays)

OutboxRelays means "make sure we have at least one of these in our active set"

[ksedgwic]

It might be useful to have a SubConstraint::Local which only queries local and doesn't alter remote subscriptions

[jb55]

liking the sounds of this so far!

[ksedgwic]

• I force pushed the first commit, cleaning up the compiler comments etc
• the second commit makes the SubReceiver (was SubEndpoint) scoped and unsubscribes when it goes out scope.

Is the second commit a good thing? I used an Arc<Mutex<SubMgr>> to calm rust re: the SubMgr reference issues ...

[ksedgwic]

Renamed to subman

[ksedgwic]

rebased on master

[jb55]

not sure what these errors mean:

unknown_id_send: remote:f9a6ae99-0e26-4a21-9d09-d767309943a5: error: InternalError("trouble reading from rx_ended")

[ksedgwic]

not sure what these errors mean:

good catch, that is not really an error, changed it to:

             match rsub.rx_ended.next().await {
-                Some(_) => Err(SubError::StreamEnded),
-                None => Err(SubError::InternalError(
-                    "trouble reading from rx_ended".to_string(),
-                )),
+                // in both cases the stream has ended
+                Some(_) => Err(SubError::StreamEnded), // an EOSE was observed
+                None => Err(SubError::StreamEnded),    // the subscription was closed
             }

[ksedgwic]

@jb55 i added some error handling and relay pool handling improvements in the last three commits

[ksedgwic]

rebased on master

[ksedgwic]

rebased on master

[kernelkind]

why don't timelines use SubMan? https://github.com/ksedgwic/notedeck/blob/f1aec8f6a21e89a7b4b97ebcdf1b6fa9389282df/crates/notedeck_columns/src/timeline/mod.rs#L581