notedeck icon indicating copy to clipboard operation
notedeck copied to clipboard

Switching macOS system theme switches background panel color but does not update text color

Open jb55 opened this issue 1 year ago • 5 comments

Not sure what's up here

jb55 avatar May 11 '24 19:05 jb55

https://groups.google.com/a/damus.io/g/patches/c/Q2MoZyuIiLs/m/zjYzGqCLAAAJ

See the description for this patch series:

Note: I don't believe egui currently supports setting the default 'dark' and 'light' themes, so the correct light/dark themes specified in LightTheme and DarkTheme won't get switched to when the user changes their system theme; the app theme will be changed to the egui::Visuals::dark() or egui::Visuals::light().

kernelkind avatar May 11 '24 19:05 kernelkind

On Sat, May 11, 2024 at 12:29:52PM GMT, kernelkind wrote:

https://groups.google.com/a/damus.io/g/patches/c/Q2MoZyuIiLs/m/zjYzGqCLAAAJ

See the description for this patch series:

Note: I don't believe egui currently supports setting the default 'dark' and 'light' themes, so the correct light/dark themes specified in LightTheme and DarkTheme won't get switched to when the user changes their system theme; the app theme will be changed to the egui::Visuals::dark() or egui::Visuals::light().

hmm maybe we should report/fix this upstream then.

jb55 avatar May 11 '24 20:05 jb55

hmm maybe we should report/fix this upstream then.

Yeah, I can do that

kernelkind avatar May 12 '24 14:05 kernelkind

For our reference, I believe it is occurring here:

https://github.com/emilk/egui/blob/c3f386aa301f26106397c4e14434bd5a734ba6b6/crates/eframe/src/native/epi_integration.rs#L271

https://github.com/emilk/egui/blob/c3f386aa301f26106397c4e14434bd5a734ba6b6/crates/eframe/src/epi.rs#L501C1-L508C1

kernelkind avatar May 12 '24 17:05 kernelkind

I submitted a feature request: https://github.com/emilk/egui/issues/4490

kernelkind avatar May 12 '24 17:05 kernelkind