notedeck icon indicating copy to clipboard operation
notedeck copied to clipboard

NIP-51 bookmarks

Open alltheseas opened this issue 2 years ago • 6 comments

User Story

As a pleb user of notedeck who would like to save a note, I would like to bookmark a note that interests me, so that I can access it at a later time.

Acceptance Criteria

  1. Pleb can bookmark a note
  2. After pleb bookmarks a note, this is indicated visually
  3. All bookmarks can be accessed as a stand-alone bookmarks column (see design below)
  4. Saved bookmarks are reverse chronological sorted (most recent bookmark at top)
  5. Pleb has option to remove individual bookmarks
  6. Pleb has option to clear all bookmarks (ask for confirmation:" Are you sure you want to clear ALL your bookmarks?")

Design

Image

Technical

-blocked by replaceable events in nostrDB -read bookmark kind XXXX -save bookmarks as kind XXXX

alltheseas avatar Nov 30 '23 21:11 alltheseas

@alltheseas this seems interesting to work on, just need to clarify how big the scope is before I start.

So basically we want to add a button to the side panel similar to damus with the list of bookmarks:

Image

and a button under the note content to bookmark the note.

So here we are focusing on kind 10003 bookmarks and we are for now limiting to "e" (kind:1 notes) type bookmarks. Or there is more to do here?

kuba-04 avatar Mar 18 '25 09:03 kuba-04

Good questions @kuba-04.

I added a user story, and criteria to the top of the ticket.

~~I would suggest the following order of operations:~~

  1. ~~Implement local only bookmarks first~~
  2. Add NIP-51 compatibility. That is 2a) read NIP-51 bookmarks associated with a particular key from a relay 2b) write bookmarks per NIP-51 associated with a particular key to a relay

I'll let @kernelkind confirm the specific kind, NIP for bookmarks.

As for design, refer to ~~bookmarks side menu~~ design in Figma by @robagreda

https://www.figma.com/design/aONNEWCxHlckZJq0lHyxrN/Notedeck?node-id=12-401&p=f&t=8lnGeCCA4H9c8mnO-0

@robagreda @jb55 do y'all envision a stand-alone "bookmarks" column as the UI for re/viewing bookmarks on notedeck?

alltheseas avatar Mar 18 '25 16:03 alltheseas

I don't think we need a bookmarks button in the side bar, just make it a new column. I don't think nostrdb supports replaceable events yet FYI, but this should be coming soon

kernelkind avatar Mar 18 '25 16:03 kernelkind

I don't think we need a bookmarks button in the side bar, just make it a new column

good point. @robagreda has it as a new column type in the design:

Image

Looks like this ticket is blocked by replaceable events. @kernelkind is only the NIP-51 portion blocked by replaceable events, and/or is the local bookmarks blocked as well?

alltheseas avatar Mar 18 '25 16:03 alltheseas

Local bookmarks that aren't stored in ndb would technically work I think, but I wouldn't suggest doing it that way. It would be best if they were stored in ndb, much less work and maintenance

kernelkind avatar Mar 18 '25 17:03 kernelkind

got it, thanks for the clarification. Picking up something else for now

kuba-04 avatar Mar 18 '25 17:03 kuba-04