damus
damus copied to clipboard
damus-io
https://damus.io/note link opens up Snort.social, and not in Damus [Bug][UX]
What happens When clicking on a https://damus.io/etc link in Damus app, the default behavior is to open snort.social, and not open the link in Damus app same as @note type link.
What I think should happen https://damus.io/etc note link should open in Damus app, not in an external browser client like snort.
Video: https://user-images.githubusercontent.com/64376233/221256564-11411c2c-f99f-4988-841e-0460c9c48462.mp4
Link: https://damus.io/note1hgdgp4wc8kmvc2ya63pxa27n4yyc8wz44v359xknht6wekgsk7nslp4z3t
I agree. Maybe we could even have it so that we parse the https://damus.io/note_identifier link and render it as @note_identifier instead so that it doesn't do the snort social preview and mislead the user about what will happen when they tap it.
I agree. Maybe we could even have it so that we parse the https://damus.io/note_identifier link and render it as @note_identifier instead so that it doesn't do the snort social preview and mislead the user about what will happen when they tap it.
Will you take this issue on @bryanmontz ? 🙏
Fixed in this PR, but initially Will wanted to fix it a different way. I wonder if he'd reconsider, at least for now.
https://github.com/damus-io/damus/pull/896
Fixed in this PR, but initially Will wanted to fix it a different way. I wonder if he'd reconsider, at least for now.
https://github.com/damus-io/damus/pull/896
Will does this solution work @jb55 ?
Kieran / Snort use opengraph tags https://damus.io/note1dhzgtnqun3ftzmuy90dyqedkxgqg824sg53amfe89mmc4j627z6slclvrz
Fixed in this PR, but initially Will wanted to fix it a different way. I wonder if he'd reconsider, at least for now.
#896
now that we parse urls we can just check if its a damus url and render a mention link instead. this should be super simple. doing this now
we have two options:
- leave them as links and render them as mentions
- convert them to actual mentions during post composition and parsing.
maybe 2 is better
the downside of 2 is that you can't share damus links over DMs and stuff... but at least you can always go to the note and then click share from there.