damus icon indicating copy to clipboard operation
damus copied to clipboard

Add Bookmarking (Local to device)

Open joelklabo opened this issue 2 years ago • 11 comments

Example
Simulator Screen Recording - iPhone 14 Pro - 2023-02-20 at 21 29 40

UPDATED No settings button anymore, moved to navigation bar in bookmarks view

Example (Dark) Empty State Empty State (Dark) Settings
example-dark empty example-dark settings

This just saves them (as JSON) to user defaults so only local to device.

joelklabo avatar Feb 18 '23 23:02 joelklabo

dope!

jb55 avatar Feb 19 '23 16:02 jb55

Ok, updated @jb55

joelklabo avatar Feb 19 '23 17:02 joelklabo

looks great! testing

jb55 avatar Feb 19 '23 23:02 jb55

just need a way to delete and then I can merge

jb55 avatar Feb 20 '23 16:02 jb55

just need a way to delete and then I can merge

Must be a bug but it should show "Un-bookmark" if you've already bookmarked it. I'll check again, would that work? If it worked?

joelklabo avatar Feb 20 '23 16:02 joelklabo

It shows "Bookmark".

jb55 avatar Feb 20 '23 16:02 jb55

Also we probably shouldn't have "clear bookmarks" in settings, we can just add it as a button on the top-right of the toolbar on the bookmarks view

jb55 avatar Feb 20 '23 16:02 jb55

Also we probably shouldn't have "clear bookmarks" in settings, we can just add it as a button on the top-right of the toolbar on the bookmarks view

Yeah, that would be better. I'll try that

joelklabo avatar Feb 20 '23 18:02 joelklabo

Ok, I think this is all fixed up now, updated the GIF in the description with current behavior @jb55

joelklabo avatar Feb 21 '23 05:02 joelklabo

Looks like one more thing to figure out after rebasing with master:

Cannot convert value of type 'Binding<[NostrEvent]>' to expected argument type 'EventHolder'

joelklabo avatar Feb 21 '23 05:02 joelklabo

Looks like one more thing to figure out after rebasing with master:

Cannot convert value of type 'Binding<[NostrEvent]>' to expected argument type 'EventHolder'

Should be fixed now

joelklabo avatar Feb 21 '23 05:02 joelklabo