damus icon indicating copy to clipboard operation
damus copied to clipboard

Published 20 hours ago • verified publisher icon damus-io

Delete user settings store on logout

Open tyiu opened this issue 2 years ago • 1 comments

Logout should probably get rid of all local settings tied to the pubkey. Some settings are currently global. If we want to have multi-account support in the future, we'd need to update user settings store to support that and then update the settings deletion to be scoped only to that.

tyiu avatar Feb 13 '23 00:02 tyiu

why are we deleting settings on logout? I'm confused. Then all your settings would be reset when you logout!? I logout all the time to switch accounts, this seems like it would be a bad experience.

jb55 avatar Feb 13 '23 17:02 jb55

why are we deleting settings on logout? I'm confused. Then all your settings would be reset when you logout!? I logout all the time to switch accounts, this seems like it would be a bad experience.

Hmm, that's fair. I think a better way would be to scope settings to the pubkey maybe. And then only allow writes if logged in with the privkey? Not sure

tyiu avatar Feb 13 '23 18:02 tyiu