damus
damus copied to clipboard
damus-io
Deeplink launching to profiles and notes
Showing a blank screen at the moment as damus_state not yet initialised I presume, but putting here so you guys knows this is pretty much done.
TO DO:
- Resolve damus_state initialisation [RESOLVED]
- Add instructions to Readme.md for users
- Increased error handing in DeeplinkManager
Will accept commits to the fork! :-)
ChangeLog-Changed: Added deeplink ability (using nostr://io.damus.nostr/npub1jutptdc2m8kgjmudtws095qk2tcale0eemvp4j2xnjnl4nh6669slrf04x format) (@npub1jutptdc2m8kgjmudtws095qk2tcale0eemvp4j2xnjnl4nh6669slrf04x) ChangeLog-Changed: Added additional error handling to loading contact events (@npub1jutptdc2m8kgjmudtws095qk2tcale0eemvp4j2xnjnl4nh6669slrf04x)
pretty sure we handle this already? I'm confused. see onOpenURL in ContentView
Oh - there's something in there! How do you get to fire off? Didn't think we had it implemented!
it supports the old nostr:e:hexkey and nostr:p:hexkey thing but we should make it support npub and note
OK cool. Happy to update if you like (we now have that part)? I like the method on ContentView as well as that would also resolve the damus_status issue I was having.
Speaking on ContentView - looks to me that that could do with some refactoring and using navigation tabs - although that would be quite an update I think and maybe not needed now.
Yeah I don't think nav is being done correctly, it uses a single stack which is probably wrong?
Yeah, I believe so ... but I'm no expert ... but it looks like one of those jobs you crack open and it ends up being quite a bit to sort it all out. I did actually start doing that with the design updates but soon realised we would have a merge nightmare ;-)
Updated this to work where the previous code was. It's now going to the profile page for a string such as (my nPub):
nostr://io.damus.nostr/npub1jutptdc2m8kgjmudtws095qk2tcale0eemvp4j2xnjnl4nh6669slrf04x
However, it's not loading correctly, so must be missing something at the moment. Will continue looking into it tomorrow but getting late here. I think it's something to do with the fact I'm passing the nPub as a string, but expecting hex or something.
Have abstracted the URL handler into DeepLinkManager although I haven't removed NostrLink as could be
@jb55, you mentioned you were working on the sharing links going out ... is that going via the website that redirects to nostr:// if installed or directly to nostr://? What format are you using?
I think profiles and notes not loading correctly are related to the ContentView in that another thread is running, and variables are being dynamically rewritten.
Propose that ContentView uses TabView, which has:
@State var activeTab = TabIdentifier.home
TabView() {
HomeView()
.tabItem { ... }
.tag(TabIdentifier.home) // use enum case as tag
DirectMessagesView()
.tabItem { ... }
.tag(TabIdentifier.messages) // use enum case as tag
SearchView()
.tabItem { ... }
.tag(TabIdentifier.search) // use enum case as tag
NotificationsView()
.tabItem { ... }
.tag(TabIdentifier.notifications) // use enum case as tag
}
.onOpenURL { url in
guard let tabIdentifier = url.tabIdentifier else {
return
}
activeTab = tabIdentifier
}
Some consideration is needed for jumping to a ProfileView().
This should make this application area significantly easier to maintain - although it requires quite a bit of refactoring to implement.
Ref: Adding TabView and tabItem()
Ref: Handling deeplinks in iOS 14 with onOpenURL
I see the share :-) If I paste the link in Safari it goes to damus.io but then forwards to snort.social. Not sure why - but I think the we need to change the following (or value on the right I forget) to damus.io (and the corresponding value in DeepLinkManager class if you're still using that:
that section is for uris. The feature we have now is universal links via domain association entitlement:
https://damus.io/.well-known/apple-app-site-association
If you click the link in the notes app, signal, telegram, etc it will open in damus.
Not sure why it doesn't work in some apps though.
testing link here... https://damus.io/note1ws6wdg3rgmgue2sjxqp3gkmql70nsvm4fphsgl6nr7km2y57tzpsd0gy6w
Do we want to /e/ and /p/ in the Url? (Saw that used elsewhere but technically don't need).