damus
damus copied to clipboard
damus-io
Bug: opening URL works intermittently
What happens When I click on Nostr URLs or on push notifications, the client intermittently does not open the url
What I expect to happen I expect URLs to be opened flawlessly (if it cannot find an event right away, it should retry or show a loading screen)
Link to noteID, npub N/A
Screenshots/video recording N/A
Versions
Damus version: At least 1.10 Operating system version: At least iOS 17+ Device: Any
Steps To Reproduce Steps to reproduce the behavior:
- Tap on push notifications
- Tap on damus links
Additional context
- The solution may include some form of queuing
@jb55 @alltheseas I am working on this one as it's pretty serious and it becomes a more visible issue when we rollout push notifications
Sorry @jb55 and @alltheseas, I started a draft on Friday for this but forgot about it until now, and ended up doing https://github.com/damus-io/damus/issues/751 instead 🤦♂️
I will continue working on this next! (Or please let me know if something more urgent comes up)
Descoping this from 1.10.
I paused my work on this ticket. For anyone who picks this up, here is the draft I was working on https://github.com/danieldaquino/damus/tree/%232429
@alltheseas, @jb55, I sent a patch via email to resolve this!
Please let me know if there are any suggestions, questions, or concerns. Thank you!
@alltheseas, @jb55, I sent a patch via email to resolve this!
Please let me know if there are any suggestions, questions, or concerns. Thank you!
haven't had the chance to test it but code and video look good! other than that weird quirk where navigation doesn't work if you're alreay navigating? but we can fix that later.
On Jan 10, 2025, at 23:33, William Casarin @.***> wrote:
@alltheseas, @jb55, I sent a patch via email to resolve this!
Please let me know if there are any suggestions, questions, or concerns. Thank you!
haven't had the chance to test it but code and video look good! other than that weird quirk where navigation doesn't work if you're alreay navigating? but we can fix that later.
What weird quirk are you referring to?
Daniel D’Aquino @.***> writes:
@alltheseas, @jb55, I sent a patch via email to resolve this!
Please let me know if there are any suggestions, questions, or concerns. Thank you!
haven't had the chance to test it but code and video look good! other than that weird quirk where navigation doesn't work if you're alreay navigating? but we can fix that later.
What weird quirk are you referring to?
just noticed that the links weren't working when you were already navigated somewhere, unless I'm mistaken.
On Sun, Jan 12, 2025 at 23:17, William Casarin @.***(mailto:On Sun, Jan 12, 2025 at 23:17, William Casarin < wrote:
Daniel D’Aquino @.***> writes:
@alltheseas, @jb55, I sent a patch via email to resolve this!
Please let me know if there are any suggestions, questions, or concerns. Thank you!
haven't had the chance to test it but code and video look good! other than that weird quirk where navigation doesn't work if you're alreay navigating? but we can fix that later.
What weird quirk are you referring to?
just noticed that the links weren't working when you were already navigated somewhere, unless I'm mistaken.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.
Ah, I believe that happened because I put the same event ID on multiple links, so the app was already at the destination in some cases, and so I had to go back to the home screen and try again to see the navigation happening
Example:
1:08: I click on a valid damus.io/nevent link, Damus navigates to the event 1:17: I click on a valid nostr:nevent link, which points to the same exact same event ID, so the app doesn't navigate to the new route, because it's already at that desired destination 1:20: I realize that fact, so I redo the test on the two links, this time moving away from the thread before clicking on the second valid link
I believe that when the user is on a thread and they click on another event link (with a different event ID), it will push that second route into the navigation stack. I believe I have seen that happening while I was dev testing, but it seems that I did not include that in my official test.
So I will double-check the behaviour in that case to be sure!
Daniel D’Aquino @.***> writes:
What weird quirk are you referring to?
just noticed that the links weren't working when you were already navigated somewhere, unless I'm mistaken.
Ah, I believe that happened because I put the same event ID on multiple links, so the app was already at the destination in some cases, and so I had to go back to the home screen and try again to see the navigation happening
Example:
1:08: I click on a valid damus.io/nevent link, Damus navigates to the event 1:17: I click on a valid nostr:nevent link, which points to the same exact same event ID, so the app doesn't navigate to the new route, because it's already at that desired destination 1:20: I realize that fact, so I redo the test on the two links, this time moving away from the thread before clicking on the second valid link
I believe that when the user is on a thread and they click on another event link (with a different event ID), it will push that second route into the navigation stack. I believe I have seen that happening while I was dev testing, but it seems that I did not include that in my official test. So I will double-check the behaviour in that case to be sure!
ah ok, wasn't sure. can't wait to test this!
On Jan 14, 2025, at 00:51, William Casarin @.***> wrote:
Daniel D’Aquino @.***> writes:
What weird quirk are you referring to?
just noticed that the links weren't working when you were already navigated somewhere, unless I'm mistaken.
Ah, I believe that happened because I put the same event ID on multiple links, so the app was already at the destination in some cases, and so I had to go back to the home screen and try again to see the navigation happening
Example:
1:08: I click on a valid damus.io/nevent link, Damus navigates to the event 1:17: I click on a valid nostr:nevent link, which points to the same exact same event ID, so the app doesn't navigate to the new route, because it's already at that desired destination 1:20: I realize that fact, so I redo the test on the two links, this time moving away from the thread before clicking on the second valid link
I believe that when the user is on a thread and they click on another event link (with a different event ID), it will push that second route into the navigation stack. I believe I have seen that happening while I was dev testing, but it seems that I did not include that in my official test. So I will double-check the behaviour in that case to be sure!
ah ok, wasn't sure. can't wait to test this!
Just double-checked this, and it works! Clicking on links pointing to different events will push those new thread routes on the navigation stack as expected
On Jan 15, 2025, at 11:39, Daniel D’Aquino @.***> wrote:
On Jan 14, 2025, at 00:51, William Casarin @.***> wrote:
Daniel D’Aquino @.***> writes:
What weird quirk are you referring to?
just noticed that the links weren't working when you were already navigated somewhere, unless I'm mistaken.
Ah, I believe that happened because I put the same event ID on multiple links, so the app was already at the destination in some cases, and so I had to go back to the home screen and try again to see the navigation happening
Example:
1:08: I click on a valid damus.io/nevent link, Damus navigates to the event 1:17: I click on a valid nostr:nevent link, which points to the same exact same event ID, so the app doesn't navigate to the new route, because it's already at that desired destination 1:20: I realize that fact, so I redo the test on the two links, this time moving away from the thread before clicking on the second valid link
I believe that when the user is on a thread and they click on another event link (with a different event ID), it will push that second route into the navigation stack. I believe I have seen that happening while I was dev testing, but it seems that I did not include that in my official test. So I will double-check the behaviour in that case to be sure!
ah ok, wasn't sure. can't wait to test this!
Just double-checked this, and it works! Clicking on links pointing to different events will push those new thread routes on the navigation stack as expected
@jb55, can I go ahead and merge this change?
Thanks!