damus icon indicating copy to clipboard operation
damus copied to clipboard

nostr:nevent1 render sometimes broken

Open alltheseas opened this issue 1 year ago • 5 comments

https://damus.io/note1dyn6qnlqm3rwnk9quajjdn2eh8ldlflt6f8szhmkjdnplyy2w0kqm583w3

image

alltheseas avatar Jan 17 '24 21:01 alltheseas

The nevent mention is valid, it's rendered correctly on Coracle

kernelkind avatar Jan 18 '24 18:01 kernelkind

looks like it has 16 relays, I wonder if it's hitting our limit (although I thought it was 16). Maybe we can just bump it to 32

jb55 avatar Jan 18 '24 18:01 jb55

also we shouldn't fail to parse if we hit the limit, maybe that is happening as well.

jb55 avatar Jan 18 '24 18:01 jb55

looks like it has 16 relays, I wonder if it's hitting our limit (although I thought it was 16). Maybe we can just bump it to 32

The TLV limit is 16, and it looks like the problem is that the TLV with the special type is the one that didn't fit in the buffer so the code thinks the mention is invalid. It looks like you increased the max TLV limit in the nostrdb changes to 32 so I think this specific issue would be fixed when the nostrdb changes are integrated into damus.

This would only be a bandaid fix though, to fix the root of this issue we would need to ensure if a special type TLV exists in the URI, it makes it to the TLV buffer

kernelkind avatar Jan 19 '24 16:01 kernelkind

The nevent linked still does not render.

a quick test reveals nostr:nevent render works

image

alltheseas avatar May 21 '24 17:05 alltheseas