damus icon indicating copy to clipboard operation
damus copied to clipboard

Published 20 hours ago • verified publisher icon damus-io

Large size media file does not load, or causes Damus crash

Open alltheseas opened this issue 2 years ago • 8 comments

what happens 50MB image does not load, or causes Damus to crash

SerSleepy: NoteID

Https://damus.io/note1fs24w4rktgwktxptu9pnpds6f92h9cygsxt3hmwtx8vwdkzgdm5q9d3m2h

alltheseas avatar May 01 '23 15:05 alltheseas

note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

alltheseas avatar Nov 13 '23 03:11 alltheseas

Consistent with other clients, can these images be progressively downloaded or display a loader animation?

Amethyst, Snort, Nostur all display it.

https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

dmnyc avatar Nov 13 '23 04:11 dmnyc

Consistent with other clients, can these images be progressively downloaded or display a loader animation?

Amethyst, Snort, Nostur all display it.

https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

@robagreda WDYT 👀

alltheseas avatar Nov 13 '23 05:11 alltheseas

Consistent with other clients, can these images be progressively downloaded or display a loader animation? Amethyst, Snort, Nostur all display it. https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

@robagreda WDYT 👀

Specifically I am interested in the user interface of letting a client know media is loading, or is not supported (e.g. due to max file size).

@jb55 mentions Damus does not have CDN, while clients like Snort do currently.

Related: low data & cellular mode #919

alltheseas avatar Nov 13 '23 18:11 alltheseas

Perhaps add a warning if an oversized image isn't loading and allow the user to tap to download it. Would that work?

dmnyc avatar Nov 13 '23 18:11 dmnyc

Perhaps add a warning if an oversized image isn't loading and allow the user to tap to download it. Would that work?

There's a couple things going on.

  1. Currently Damus has a limitation on file size. How might we communicate this @robagreda user is attempting loading a file size larger than the limit?
  2. Loading large file - should, and how might we communicate this @robagreda ? Could this UI extend to all media, not just "large" media?

alltheseas avatar Nov 13 '23 18:11 alltheseas

Notes

https://damus.io/note1fs24w4rktgwktxptu9pnpds6f92h9cygsxt3hmwtx8vwdkzgdm5q9d3m2h

note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

Do not render media. Did not experience crash.

alltheseas avatar Feb 12 '24 20:02 alltheseas

we don't load > 20MB for sanity ... ideally we would detect content size and force a proxy for larger images

jb55 avatar Sep 27 '24 18:09 jb55