subtle

subtle copied to clipboard

Support for constant-time ordering comparisons?

1

For now, the library only supports constant-time equality comparison. Could it be extended to support constant-time ordering comparisons (https://doc.rust-lang.org/std/cmp/trait.Ord.html)? In particular for slices of the same length (using lexicographical comparison)....

gendx

Add constant time warning to `unwrap_or_else` doc comment so that the user knows that the closure will not be lazy evaluated.

trevor-crypto

Implement string comparison

3

This PR implements `ConstantTimeEq` for `str`.

alvra

Remove ignored inline attributes from function prototypes

1

Attributes that are in function prototypes are ignored and emit a compiler warning. This pull request should not have any effect except removing the compiler warnings: ``` warning: `#[inline]` is...

oherrala

The analyzer warns about `#[inline]` on function prototypes. While it seems useful to keep the attribute around as a helpful reminder in relevant traits, this PR silences the warnings.

AaronFeickert

The current implementation of `ConstantTimeEquality` for arrays and slices will short-circuit if the lengths are different. This PR does a constant-time length check before the componentwise check, and then uses...

AaronFeickert

Add `ConstantTimeSelect` and `ConstantTimeClone` traits

3

`ConstantTimeSelect` is intended as a replacement to `ConditionallySelectable`, which is preserved but deprecated. It replaces the previous `Copy` bound with a bound on a new `ConstantTimeClone` marker trait, which allows...

tarcieri

add usize/isize to generated trait impls

2

It seems like `usize` and `isize` could reasonably be allowed to implement `ConstantTime{Greater,Less}` via the macros that are already used for other integer types. I assumed it was an oversight...

cosmicexplorer

This generalizes the implementation of `ConstantTimeEq` for `[T]` to also support `ConstantTimeGreater` and `ConstantTimeLess`. I haven't touched the implementation of `ConstantTimeEq for [T]` as the standalone implementation is more efficient...

conduition

Use predication intrinsics (i.e. CMOV) for `ConditionallySelectable`

2

The foundation of `ConditionallySelectable` is bitwise masking of values + XOR, using the input `Choice` to generate a conditional mask, such that the mask erases one of the two values...

tarcieri