ed25519-dalek icon indicating copy to clipboard operation
ed25519-dalek copied to clipboard

WIP Updated deps

Open rozbb opened this issue 4 years ago • 2 comments

This depends on https://github.com/dalek-cryptography/curve25519-dalek/pull/369. The tests don't currently compile because curve25519-dalek expects the wrong version of rand. Also, this requires a major version bump for the same reason as the aforementioned PR.

Notes on the deps I updated:

rozbb avatar Sep 14 '21 07:09 rozbb

@rozbb I found that curve25519-dalek's 4.0.0-pre.1 already has the new version of rand.

weikengchen avatar Dec 06 '21 04:12 weikengchen

I made these changes to get things to work with curve25519-dalek 4.0.0-pre.2: https://github.com/stephank/ed25519-dalek/commit/808b1e6f8a546345787261640c6c237f11ca0e19. CI passes.

It looks like the ed25519 crate has raised MSRV to 1.56 in a minor release, because it switched to Rust 2021. We could restrict its version to >=1, <1.4, or raise the MSRV here. I chose the latter because this is a change for a major release any way.

stephank avatar Jun 26 '22 11:06 stephank

Fixed in release/2.0

rozbb avatar Dec 20 '22 11:12 rozbb