clj-http icon indicating copy to clipboard operation
clj-http copied to clipboard

Misnamed keyword on exception type?

Open MarcusSky opened this issue 5 years ago • 2 comments

Hey guys, I was looking through the code, and I noticed that here we're naming the keyword unexceptional-status - shouldn't it be namedexceptional-status since unexceptional-status-for-request? returned false ?

MarcusSky avatar Sep 21 '20 21:09 MarcusSky

This is my first time looking at the implementation, and I also think it would be better named as exceptional-status.

To avoid breaking the library for existing users, I think it's preferrable to leave it as-is for the 3.x branch. We can consider changing this behaviour perhaps for 4.x which is still in early stages.

rymndhng avatar Sep 27 '20 22:09 rymndhng

Sounds fair! should I open a pull request?

MarcusSky avatar Sep 28 '20 21:09 MarcusSky