clj-http icon indicating copy to clipboard operation
clj-http copied to clipboard

README example for build-async-http-client (with async conn manager) is wrong

Open ejschoen opened this issue 6 years ago • 4 comments

The example code shows passing false for the proxy-ignore-hosts parameter. It looks like it should be an empty sequence; else this is an exception: java.lang.IllegalArgumentException: Don't know how to create ISeq from: java.lang.Boolean exception from under clj-http.core/get-route-planner.

ejschoen avatar Oct 25 '19 00:10 ejschoen

@ejschoen thanks for noticing this, would you be able to open a PR for fixing this?

dakrone avatar Nov 07 '19 16:11 dakrone

Done. #524.

ejschoen avatar Nov 08 '19 12:11 ejschoen

#531 fixes this a little differently (I ended up dropping the proxy params because they were optional).

wmatson avatar Jan 27 '20 13:01 wmatson

#531 has been merged

wmatson avatar Feb 06 '20 17:02 wmatson