clj-http icon indicating copy to clipboard operation
clj-http copied to clipboard

Experiment with Apache HTTP 5.0 upgrade

Open dakrone opened this issue 7 years ago • 5 comments

The new Apache 5.0 client is out now for alpha/beta, I should experiment with upgrading (on 4.x branch only) since it supports things like HTTP 2.0

dakrone avatar Feb 21 '18 03:02 dakrone

@dakrone Have you make progress on this? I couldn't find a 4.x branch to look at.

rymndhng avatar Sep 15 '20 17:09 rymndhng

This is basically the master branch. I think, however, that it's sorely out of date, and doesn't support 100% of what 3.x does. Apache seems to break things pretty badly between major versions, so it's a difficult task to migrate to the new client.

dakrone avatar Sep 17 '20 17:09 dakrone

Thanks, if it's is OK with you, I can try to spend some time investigating this.

My plan is to get the tests passing to help inform what the migration plan could look like.

I've started this on branch x-4.x-apache5-upgrade-experiment. It branches off 3.x branch and merges in master.

rymndhng avatar Sep 18 '20 18:09 rymndhng

That sounds great!

dakrone avatar Sep 18 '20 18:09 dakrone

Okay! the branch has all tests passing 🎉!

I've finally had some time to digest & summarize my recommendations. I've written up my recommendations here: https://github.com/dakrone/clj-http/pull/561/files#diff-5d2f2c8ca613effd76b40cdeae8456d8

rymndhng avatar Oct 03 '20 00:10 rymndhng