daimaxiaxie

Results 25 comments of daimaxiaxie

@sftim I mean nodeoverlay can provide more overlay options, not just resources. For example, Lables.

What is the progress now? Why does it seems not to be updated.

It seems that `karpenter.sh/unregistered` also has this problem? What is the problem now?

Can anyone merge it? It’ been blocked for a long time. Thanks! @x13n

> The reason is that there is no point keeping a VM that cannot register; it's not really providing capacity to kubernetes cluster. Min size is there to guarantee a...

> Actually a good question is why do we have such a check in https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/core/static_autoscaler.go#L785. That feels really inconsistent, why are we ok going below min in deleteCreatedNodesWithErrors, but not...

Hi @x13n , I updated the code and now only respects MinSize in `fixNodeGroupSize`. Hope it can be reopened. Respecting MinSize is necessary in `fixNodeGroupSize`, even with `ForceDeleteNodes`, because `fixNodeGroupSize`...

> Hi [@daimaxiaxie](https://github.com/daimaxiaxie) , > What version of Karpenter are you running inside your cluster? Karpenter-core v1.2.0 This is only the `skipping, nodepool requirements filtered out all instance types` log.