apps icon indicating copy to clipboard operation
apps copied to clipboard

refactor: invalid username error message to clarify the accepter format

Open PredictiveManish opened this issue 1 year ago • 2 comments

https://github.com/dailydotdev/docs/issues/400

This issue is solved in this PR.

This PR changes the error message seen by user during registering and having their username.

  • When people select/enter their username- It was showing username is invalid but not showing what is the requirements.
  • This issue is raised in the docs repo of daily.dev.

image

Summary-

This issue will help users to find out name format so that they can easily register and make their account freely.

PredictiveManish avatar Oct 15 '24 07:10 PredictiveManish

@PredictiveManish is attempting to deploy a commit to the Daily Dev Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 15 '24 07:10 vercel[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 15 '24 07:10 CLAassistant

I think your previous PR was better. Let's reopen that instead and I will have it merged.

For reference: https://github.com/dailydotdev/apps/pull/3674

sshanzel avatar Oct 23 '24 19:10 sshanzel

I think your previous PR was better. Let's reopen that instead and I will have it merged.

For reference: #3674

It was deleted that's why I opened this.

PredictiveManish avatar Oct 24 '24 03:10 PredictiveManish

Yeah, you closed it, but it was actually a valid one.

Sorry, I mean this one https://github.com/dailydotdev/apps/pull/3661

sshanzel avatar Oct 24 '24 07:10 sshanzel

Yeah, you closed it, but it was actually a valid one.

Sorry, I mean this one #3661

I got your point but I deleted the previously forked repository and now I am unable to access that PR.

PredictiveManish avatar Oct 24 '24 11:10 PredictiveManish