apps icon indicating copy to clipboard operation
apps copied to clipboard

Published 20 hours ago • verified publisher icon dailydotdev

feat: add shortcuts component storybook

Open ilasw opened this issue 1 year ago • 2 comments

Changes

  • Upgrade Storybook to v8;
  • Soft refactored ShortcutLinks component for enhance readability;
  • Added ShortcutLinks to Storybook;
  • Added mock for mandatory business logic functions/libraries (node-fetch, webextension-polyfill, useLogSharedProps, browser from extensions context);
  • Added API mock for mandatory /api/boot fetch;

Manual Testing

[!CAUTION] Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-405-shortcuts-component-storybook.preview.app.daily.dev

ilasw avatar Jul 02 '24 13:07 ilasw

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 6:56am
storybook ❌ Failed (Inspect) Jul 5, 2024 6:56am

vercel[bot] avatar Jul 02 '24 13:07 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 02 '24 13:07 CLAassistant

Ideally Storybook only cares about components with data coming from elsewhere. I know our components are now not always build in this way, but maybe something we should strive for in the long term?

I totally agree. Actually there is a bond too strong between UI and business logic and it is hard to separate them, but if we do it, it will pay in the long run!

ilasw avatar Jul 04 '24 07:07 ilasw