Add a way to disable on arbitrary sites

[dadler]

Add a way to disable Thumbnail Zoom Plus on arbitrary user-specified sites or pages.

Example: Thumbnail Zoom Plus doesn't have any logic specific to reddit.com. It merely displays images and videos when the hovered link points directly to an image or video. That's handled in the "Others" rule, so disabling Others will disable reddit.com, but it may also disable the add-on on other sites where the user does want them.

Suggested in user review https://addons.mozilla.org/en-US/firefox/user/1865642/ by [email protected] .

Also suggested by comment on wordpress page http://thumbnailzoomplus.wordpress.com/manual/preferences/#comments

[dadler]

"This is basically the same issue as #40: Change Site 'Enable' GUI To Support More Sites".

[dadler]

This is preliminarily implemented in the "site-disable-pref" branch on github, but not yet released in an alpha or beta.

As currently implemented it lets the user define a list of patterns. If the pattern matches the URL of the page hosing the thumbnail or link, the page is disabled and no pop-up will be shown. Patterns support "*" and "?" wildcard characters. Patterns must fully match the URL (except the protocol part like "http://").

Preferences are now divided into three tabs: General, Disabled Sites, and Site Checkboxes. The latter is the list of pre-defined site checkboxes; this will be phased out after the Disabled Sites feature is proven successful.

[dadler]

Open issues with the current implementation:

• Changes to the disabled-sites list don't apply until a page is reloaded.
• May need speed optimization, especially if the disabled-site list is long. It currently tests each regexp independently, but might be faster if isURLEnabled() built a combined regexp only when the pref changes, and tests that in a single operation.
• Untested in older Firefox versions.
• Prefs dialog: should disable "Remove" button when no site is selected.
• There is no option to default to disabling all pages, and enable only specific pages.
• There is no option to disable by image URL (only by hosting page URL).
• Users may be confused between Disabled Sites and Site Checkboxes tabs; remove or add label explaining them?
• Difficult to use with frames: exclusion and default add are based on top-level page, but URL is tested against frame/iframe's URL. Example: editing Word document on skydrive (live.com).

[dadler]

This is now available in 3.0beta1. https://addons.mozilla.org/en-US/firefox/addon/thumbnail-zoom-plus/versions/