thumbnail-zoom
thumbnail-zoom copied to clipboard
dadler
Pop-ups sometimes show "!" error if HTTPS Everywhere is enabled
It seems that direct links to the image file on Imgur and album URLs that look like http://imgur.com/a/* are working without any issues.
But URLs that look like http://imgur.com/* are only showing that little warning triangle.
A good showcase for this issue is this subreddit: https://www.reddit.com/r/androidthemes/ This issue appears on Firefox 36 and both Windows and OS X.
[Edit by David Adler: it happens on facebook.com too]
I'm not having this problem when I check the Imgur images on that Subreddit. Latest Firefox, TZP, and Mac. Post a problematic Imgur link directly here so we can take a look.
Yep, that subreddit seems to work for me.
Make sure you're running the current version of TZP (3.3) and that in Preferences you have turned on sites Imgur, Others, and Others (Indirect). I'm guessing you may have "Others" off.
I have the same problem except it's random imgur urls, sometimes http://imgur.com/a/* works and sometimes not.
screenshot: http://imgur.com/79jXVgh
edit: I'm also running 3.3 and have Imgur, others, and other (indirect) turned on, add example
The screenshot of biotechdj is from reddit post http://www.reddit.com/r/keto/comments/32ca7m/breakfast_of_champions_fp/ . That post works fine for me and I haven't reproduced the problem, but I've seen other users report it too.
Perhaps it's a conflict with another add-on or some reddit setting.
Are you using the Reddit Enhancement Suite? If so, does the problem happen if you disable it? Does the problem happen you you disable all add-ons other than TZP (and restart)?
determined it was HTTPS-Everywhere 5.0.2, testing diff setting after work.
edit: I went through and turned off the rules one by one with no effect. It will only work if you disable HTTPS-Everywhere through it's settings or add-ons.
Thanks for testing and reporting that! I'll see if I can figure out what the conflict is.
I can sometimes reproduce the problem after installing Https Everywhere from https://addons.mozilla.org/en-us/firefox/addon/https-everywhere/ and hovering this link from the gitlab page you're viewing now: http://imgur.com/79jXVgh
Error message in console: 11:42:50 PM.255: ThumbnailZoomPlus: <<< SEEKING image for name="a" class="" url= http://imgur.com/79jXVgh pageUrl=https://github.com/dadler/thumbnail-zoom/issues/207#issuecomment-92818485 23:42:50.256 11:42:50 PM.256: ThumbnailZoomPlus: !!! PAGE 'others' (27) matches imageSource http://imgur.com/79jXVgh 23:42:50.257 11:42:50 PM.257: _getZoomImageCompletionImmediate: getZoomImageResult=http://imgur.com/79jXVgh.jpg; type=string 23:42:50.257 11:42:50 PM.257: ThumbnailZoomPlus: >>>------ page others LAUNCHING http://imgur.com/79jXVgh.jpg 23:42:50.258 TypeError: value is not a non-null object tabbrowser.xml:430:17 23:42:50.334 TypeError: value is not a non-null object tabbrowser.xml:430:17 23:42:50.337 11:42:50 PM.337: ThumbnailZoomPlus: >>> error loading http://imgur.com/79jXVgh.jpg
The tabbrowser.xml line is the return statement in:
<method name="getTabForBrowser">
<parameter name="aBrowser"/>
<body>
<![CDATA[
return this._tabForBrowser.get(aBrowser);
]]>
</body>
</method>
I don't know why this happens TZP doesn't call getTabForBrowser. Perhaps HTTPS-Everywhere does.
The problem doesn't seem to happen with HTTPS Everywhere 4.0.3 from https://www.eff.org/https-everywhere
I can't reproduce this anymore with Firefox 39a2 and TZP 3.4beta1 and HTTPS-Everywhere 5.0.2. In the console Firefox only complains about imgur's SHA-1 certificate but TZP is now showing the previews for all imgur links.
The only big change that I did recently was to switch from Firefox Stable to Aurora/Dev Edition.
Good to know!
It works in Firefox Beta 38.0, too (with HTTPS-Everywhere 5.0.2 and Thumbnail Zoom Plus 3.3 or 3.4beta1).