pimcore-members
pimcore-members copied to clipboard
Allow (Inherited) Folder Restriction In Data Object/Document Tree
| Q | A |
|---|---|
| Branch? | 4.x |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #190 |
Hey @blankse, if this is still relevant (this year was one hell of ride for us, so sorry for my very very late reponse):
Could you rebase this on 5.x (remove the o_ prefix)?
I also just checked your PR and there is this (quite big) issue, described in the ticket (#190):
"Check if children are valid candidates (based on allowed_objects for data objects, and page for documents)"
It's quite hard, to determinate if there are matching object within the folder, there could be thousand of objects in there. So I think there is more work to do.
However, I also noticed within your PR:
- Documents:
- It seems to work: Only documents of type
pagewill be recognized, also the ui in backend (folder icon) applies correctly
- It seems to work: Only documents of type
- Objects, if I'm applying groups to the object folder:
- no icon appears (because of the missing check in
TreeListener) on folder level - a restriction will be added to all its children, regardless of the configured classes which is not what we want (only apply them to the configured
allowed_objects
- no icon appears (because of the missing check in
@solverat I will close the pull request. No longer needed by us at the moment. If it changes, I will create a new PR for 5.x.