ngSmoothScroll
ngSmoothScroll copied to clipboard
V2.0.0 possible bug for condition for stopAnimation
Hi, In the new version 2.0.0, you have in line 127:
scrollHeight = document.body.scrollheight;
The correct attribute is: scrollHeight (H in uppercase). It's ok in version 1.1.7:
scrollHeight = document.body.scrollHeight;
Not a bug but for condition 1 and 2, use '===' (instead ==) in line 123 et 125,
if (
( // condition 1
position === endLocation
) ||
( // condition 2
currentLocation === endLocation
) ||
Philippe
+1 - would be nice with a quick fix as this one is keeping us from upgrading to 2.0.
When i use 2.0 instead of 1.1.7 it has this behaviour; (on iPhone)
- Button clicked
- Browser scrolls to anchorpoint
- User scrolls a little up to see the button again and clicks on it
- Browser scrolls up but stops to scroll down
With version 2.0 it has the same functionality as shown above only it scrolls also down again. I don't know if any other people have this? Now it flicks the browser scroll around from bottom to top and bottom again. It isn't a nice animation now.