ChangZhuo Chen (陳昌倬)

Results 68 comments of ChangZhuo Chen (陳昌倬)

3 is fixed in https://github.com/chewing/libchewing/issues/89

@AIdrifter Please take a look at review result, thanks.

目前需要自行編譯 https://github.com/chewing/libchewing。在編譯過程中,如果 tsi.src 有修改就會產生字典檔 `dictionary.dat` 和 `index_tree.dat`。 你也可以把改好的字典檔發 pull request 送回來,這樣下次 release 就會有你修改好的部份了。

The `ChewingContext` is only exported as pointer in public API, so I don't think bumping soversion is needed.

`chewing_Configure` and `ChewingConfigData` are both deprecated, so we shall keep them as is (e.g. https://github.com/chewing/libchewing/commit/77acaf9b52f0b85e428afb08b1acaf284eb92634).

Not sure if it worth, so just pending now.

@kidwm Current libchewing does not have word to bopomofo mapping table, so it cannot to the check. Since there are many error handle cases that needs this table, we might...

We just want to run valgrind when `make test`, and integrate this into CI system. In 507707efb5f383fdcfb59ef9cfe4196b73da57f1, valgrind is okay in `make test`. However, it is useless now because too...

Is it possible to use https://cmake.org/cmake/help/v3.0/module/FindGTest.html to find gtest in ubuntu build?