ESM support for extensions

[maxkfranz]

Description of new feature

What should the new feature do? For visual features, include an image/mockup of the expected output.

Technical background:

• ESM is now the module standard for JS.
• The existing extensions largely use Webpack to build UMD (CJS, AMD, globals). They should use Rollup to build ESM and UMD in future.
• The main library already uses Rollup to build ESM and UMD.
• rollup-starter-lib, or something like it, may be a good starting point. For the template, we may be able to fork it to add some Cytoscape examples.

Goals:

• Build a template extension using a Github template repository.
• Use your template to update the main first-party extensions.
• Add the template extension to the documentation. A new app author should just click a button to get a new repo for their extension on GitHub. Then they can just focus on their extension itself.

Motivation for new feature

Describe your use case for this new feature.

• A lot of JS projects now, and any recent projects, use ESM (either natively in the browser or with a bundler). The core Cytoscape.js library supports ESM. The extensions do not.
• Someone using ESM would have to do complicated configurations to make the extensions work with a bundler.
• Someone using ESM directly in the browser would have to use workarounds in their own code to make extensions work. This would not be straightforward, especially for novices.
• It’s difficult for someone to contribute an extension, unless they’re fairly well skilled technically.

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

• [ ] Ensure that the reporter has adequately described their idea. If not, elicit more information about the use case. You should iteratively build a spec together.
• [ ] Ensure that the issue is a good fit for the core library. Some things are best done in extensions (e.g. UI-related features that aren't style-related). Some things are best done by app authors themselves -- instead of in Cytoscape libraries.
• [ ] The issue has been associated with a corresponding milestone.
• [ ] The commits have been incorporated into the unstable branch via pull request. The corresponding pull request is cross-referenced.

[Foxtrot-14]

Hello, I have made a template repository and made a Pull Request on automove extension. I request you to kindly assign me the issue. So, I can make the same changes on all the extensions.

[maxkfranz]

@Foxtrot-14, it's great that you've started on the extension template.

Would you link to the PR you mentioned? I do not see it listed in the automove extension repo: https://github.com/cytoscape/cytoscape.js-automove/pulls

[Foxtrot-14]

@Foxtrot-14, it's great that you've started on the extension template.

Would you link to the PR you mentioned? I do not see it listed in the automove extension repo: https://github.com/cytoscape/cytoscape.js-automove/pulls

I think the PR is closed because I deleted the forked repo, give me some time I will make the PR again, meanwhile let me know whether the template is correct.

[maxkfranz]

Let's use the upcoming PR that you'll post to discuss the correctness of the template. The PR review features will allow us to discuss particular parts of it more effectively than in this issue and in email.

Looking forward to your PR.

[Foxtrot-14]

Hello, I have made the PR again. Kindly acknowledge the same.

[maxkfranz]

@Foxtrot-14, I’ll review later this week as soon as I have time.

[Foxtrot-14]

Hello max, just a gentle reminder...I am still waiting for you to review the PR and assign the issue to me.

[maxkfranz]

I don’t have time until MondayOn Oct 12, 2023, at 09:28, Noaman Ahmed @.***> wrote: Hello max, just a gentle reminder...I am still waiting for you to review the PR and assign the issue to me.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

[Foxtrot-14]

No issues.

[maxkfranz]

See also

• #3217