Events style is not dynamically applied

[Ahmed-username]

Before you post

A request for help or a requests for a how-to should be directed to Stack Overflow: http://stackoverflow.com/questions/tagged/cytoscape.js

Environment info

• Cytoscape.js version : 3.20.0
• Browser/Node.js & version : Google Chrome Version 101.0.4951.59 (Official Build) (64-bit)

Current (buggy) behaviour

Events style is not applied when dynamically added/removed from an element.

Desired behaviour

Applying "events: no" or "events: yes" should be considered even when applied after the element has been created.

Minimum steps to reproduce

To replicate the bug check this JsBin When the node is clicked, a log is printed conforming that the tap event is handled normally. However when the "Add .no-event" button is clicked, a class is added that adds the attribute "events: no" to the node, yet when the node is clicked the events are handled normally.

On the other hand, this JsBin has "events:no" applied when the node is created, and the tap event is not picked up as expected. But when the "Remove .no-event" button is clicked, the click event is still not picked up although the "events:no" style has been removed.

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

• [x] Ensure that the reporter has included a reproducible demo. They can easily fork this JSBin demo: http://jsbin.com/fiqugiq
• [ ] The issue has been associated with a corresponding milestone.
• [ ] The commits have been incorporated into the corresponding branches. Bug-fix patches go on
  • [ ] master,
  • [ ] unstable, and
  • [ ] the previous feature release branch (e.g. 1.1.x if the current release is 1.2).
• [x] The issue has been labelled as a bug, if necessary.

[maxkfranz]

It's important that the issue template is used and filled in completely in order for issues to be addressed properly and promptly. Please edit your issue according to the template. I've started it for you.

[Ahmed-username]

Thanks @maxkfranz for your help. I have amended the issue, hopefully its better now

[stale[bot]]

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

[maxkfranz]

@mikekucera, could you take a look at this one? Now that the issue is following the template, there should be enough information to reproduce this in the debug page.

[Ahmed-username]

Hello, Any updates about this issue?

thanks

[maxkfranz]

@Ahmed-username,

We carefully consider the impact and severity of each issue in conjunction with the priority of the other issues and plans across other Cytoscape projects.

This issue is on the radar.

If this issue is of significant priority to you, then you're welcome to post a pull request to expedite its resolution. I'd be willing to set aside some time to ensure that it gets reviewed and merged.

[maxkfranz]

@mikekucera has resolved the issue in #3151, and this change will be released in 3.26.1 and 3.25.2.

Closing