github-action icon indicating copy to clipboard operation
github-action copied to clipboard

Published 20 hours ago • verified publisher icon cypress-io

fix: 🐛 action not working in windows or with pnpm

Open stormslowly opened this issue 3 years ago • 2 comments

why not working with windows when install == false

action export the CYPRESS_CACHE_FOLDER env variable, so cli can not find the binary to execute; but binary is already installed by package manager in another cache folder( (ref)[https://docs.cypress.io/guides/references/advanced-installation#Binary-cache], so according the link, it will ethier not working on mac os)

solution

don't export the env variable, if cypress bin is not installted by the action

why not working with pnpm when install == true

after install action will generate hash from yarn.lock or npm-lock.json, but pnpm dont generate these two files.

solution

user specify the hash file, it will be flexiable to working with new locking files.

stormslowly avatar Jun 20 '22 02:06 stormslowly

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 20 '22 02:06 CLAassistant

@admah do you have some comments on this pr ? could you plz approve the workflow

stormslowly avatar Jun 30 '22 02:06 stormslowly

Hi @stormslowly

I was looking at your PR and trying to understand it. It looks like there are some inconsistencies using install-only on Windows. Are you still interested in working on this?

If yes, then I would suggest trying to write up a reproducible example of the issue, then when that is clear, looking at the best way to resolve it.

You proposed some changes in this PR, however they are incomplete. You would need to add some documentation and you would need to re-build the action as well. Also, as quite some time has passed since you submitted the PR, you would need to rebase it on the current master branch. For the time-being, and assuming that you are still interested, I would suggest that you put your PR into draft state.

MikeMcC399 avatar Feb 02 '23 07:02 MikeMcC399

@stormslowly

Thanks for putting your PR into a draft state, however it is now three months ago and I haven't seen a reproducible example of the problem yet. Also your branch is > 200 commits behind the master branch.

It may be time to just close this now and revisit if you have time at a later stage.

MikeMcC399 avatar May 25 '23 15:05 MikeMcC399

@stormslowly

  • Perhaps your concerns have been addressed as a workaround in PR https://github.com/cypress-io/github-action/pull/1043?
  • Also I logged an enhancement request https://github.com/cypress-io/github-action/issues/1044

MikeMcC399 avatar Oct 10 '23 17:10 MikeMcC399