github-action
github-action copied to clipboard
Fix confusing start command label
Removed extra comma
Remove command from the label since the command is logged afterwards
Thanks @fbiville, good find! Can you please rebase or merge the latest master branch so this is up to date and then push up your changes after running npm run build so the that index file is rebuilt? Then I'll be able to merge this 👍
@fbiville
Before you execute npm run build, first run npm run format i.e.
npm run format
npm run build
npm run format changes the source into one line:
return execCommand(startCommand, false, `start server`)
- otherwise this will trip us up when PR https://github.com/cypress-io/github-action/pull/766 is merged.
https://github.com/cypress-io/github-action/actions/workflows/example-webpack.yml is one of the simpler workflows which shows the issue in the log:
start server "npm start command "npm start"
After your fix is applied the log shows:
start server command "npm start"
So this is a nice improvement!
@fbiville
I see that you submitted this PR more than one year ago. If you are no longer interested in seeing it through then it would be great if you could reply. I would pick it up and put your suggestion into a new PR in that case.
(See https://github.com/cypress-io/github-action/commit/c373d352a37583fd1a44232a258008c8b2dfacec)
@fbiville
- In the process of checking this PR I actually did all the work necessary to bring it up to date, so instead of asking you to repeat the work, I have opened a new PR https://github.com/cypress-io/github-action/pull/785 which credits you with having provided the solution and is ready to merge as a fix for the current version.
Thanks @MikeMcC399. I'll close this one down so we can move ahead.
Was in vacation last week, great to see the fix is happening in some form :)
@fbiville Thanks for getting back to us! I expect that your fix will soon be merged.
@fbiville
- PR #785 is merged and you now have
Contributorshowing against your name 💪🏻 as recognition for your submission.