github-action icon indicating copy to clipboard operation
github-action copied to clipboard

Fix confusing start command label

Open fbiville opened this issue 3 years ago • 1 comments

Removed extra comma

Remove command from the label since the command is logged afterwards

fbiville avatar Jan 14 '22 17:01 fbiville

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 14 '22 17:01 CLAassistant

Thanks @fbiville, good find! Can you please rebase or merge the latest master branch so this is up to date and then push up your changes after running npm run build so the that index file is rebuilt? Then I'll be able to merge this 👍

jaffrepaul avatar Feb 10 '23 00:02 jaffrepaul

@fbiville

Before you execute npm run build, first run npm run format i.e.

npm run format
npm run build

npm run format changes the source into one line:

    return execCommand(startCommand, false, `start server`)
  • otherwise this will trip us up when PR https://github.com/cypress-io/github-action/pull/766 is merged.

https://github.com/cypress-io/github-action/actions/workflows/example-webpack.yml is one of the simpler workflows which shows the issue in the log:

start server "npm start command "npm start"

After your fix is applied the log shows:

start server command "npm start"

So this is a nice improvement!

MikeMcC399 avatar Feb 10 '23 10:02 MikeMcC399

@fbiville

I see that you submitted this PR more than one year ago. If you are no longer interested in seeing it through then it would be great if you could reply. I would pick it up and put your suggestion into a new PR in that case.

(See https://github.com/cypress-io/github-action/commit/c373d352a37583fd1a44232a258008c8b2dfacec)

MikeMcC399 avatar Feb 10 '23 12:02 MikeMcC399

@fbiville

  • In the process of checking this PR I actually did all the work necessary to bring it up to date, so instead of asking you to repeat the work, I have opened a new PR https://github.com/cypress-io/github-action/pull/785 which credits you with having provided the solution and is ready to merge as a fix for the current version.

MikeMcC399 avatar Feb 10 '23 15:02 MikeMcC399

Thanks @MikeMcC399. I'll close this one down so we can move ahead.

jaffrepaul avatar Feb 10 '23 15:02 jaffrepaul

Was in vacation last week, great to see the fix is happening in some form :)

fbiville avatar Feb 13 '23 14:02 fbiville

@fbiville Thanks for getting back to us! I expect that your fix will soon be merged.

MikeMcC399 avatar Feb 13 '23 15:02 MikeMcC399

@fbiville

  • PR #785 is merged and you now have Contributor showing against your name 💪🏻 as recognition for your submission.

MikeMcC399 avatar Feb 13 '23 19:02 MikeMcC399