github-action
github-action copied to clipboard
pull_request as trigger shows no Cypress run information on my Pull Requests
Trigger is pull_request
Passing the following environment variables to the action:
env:
COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }}
COMMIT_INFO_BRANCH: ${{ github.head_ref }}
COMMIT_INFO_SHA: ${{ github.sha }}
CYPRESS_BASE_URL: example.com
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
I expected that I was giving Cypress enough information so that it could display comments and Cypress run information on my PR but it doesn't. However, runs do show up in the dashboard with the correct meta information.
Changing the trigger to push works but we don't want that as part of our workflow.
They need to do this to get the correct SHA for pull requests: https://github.com/probablyup/wait-for-netlify-action/blob/0855dade13fa1445d67907d2b5b2ce470e38c468/index.js#L95-L96
Makes sense @probablyup! Would be nice of them to do this...
@bahmutov, any chance to get this fixed? It would help combine Cypress github action with other actions such as coveralls, which requires to run on "pull_request" action to get the comments added.
So atm, I can either have Cypress comments on PR or coveralls, but not both.