cypress-realworld-app icon indicating copy to clipboard operation
cypress-realworld-app copied to clipboard

Dockerfile added

Open Vozhak opened this issue 1 year ago • 4 comments

Provides the ability to run the app as a Docker container.

Vozhak avatar May 17 '24 14:05 Vozhak

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 17 '24 14:05 CLAassistant

cypress-app-bot avatar May 17 '24 14:05 cypress-app-bot

@mjhenkes How can I get a review?

Vozhak avatar May 19 '24 09:05 Vozhak

@Vozhak

Your PR proposes to run Cypress using the Docker image FROM node:alpine

  • Alpine Linux is however not an operating system which is supported by Cypress. See Cypress System Requirements and issue https://github.com/cypress-io/cypress/issues/419.

  • Cypress recommends using Cypress Docker images. These are already used in this repository. See .github/workflows/main.yml which uses cypress/browsers:node-20.12.0-chrome-123.0.6312.86-1-ff-124.0.2-edge-123.0.2420.65-1.

If you could demonstrate and document how to use a Cypress Docker image locally this could be a useful enhancement. You should provide exact instructions and logs showing a successful run of the tests.

MikeMcC399 avatar May 19 '24 11:05 MikeMcC399

I suggest to close this PR, since there has been no feedback on the comments.

MikeMcC399 avatar Jun 03 '24 17:06 MikeMcC399