cypress-docker-images icon indicating copy to clipboard operation
cypress-docker-images copied to clipboard

Please upgrade yarn in docker images to 1.22.22

Open vadimpopa opened this issue 1 year ago • 2 comments

What would you like?

There's yarn 1.22.22 but the images are on 1.22.19 https://hub.docker.com/layers/cypress/included/13.8.0/images/sha256-8fd74c146e3f3b0ae33f9d2864cbe7e2068434df24fc35abff913c9505eea59a?context=explore

Please upgrade yarn. Thanks

Why is this needed?

No response

Other

No response

vadimpopa avatar Apr 19 '24 13:04 vadimpopa

Transferred this issue to the cypress-docker-images repo

jennifer-shehane avatar Apr 19 '24 14:04 jennifer-shehane

This can be updated here and requires a new release of the factory: https://github.com/cypress-io/cypress-docker-images/blob/71d208a375aafeb9fa4aa8a3367b5d18126cb32e/factory/.env#L31

Publish new factory: https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md#automatic

We're open to a pull request to update this.

This issue may be related: https://github.com/cypress-io/cypress-docker-images/issues/1031

jennifer-shehane avatar Apr 19 '24 14:04 jennifer-shehane

The stable version of Yarn is still 1.22.19 according to https://classic.yarnpkg.com/latest-version and https://classic.yarnpkg.com/en/docs/install.

The reference node Docker images contain Yarn 1.22.19 (and not any later version) for this reason.

The scripts to install Yarn v1 in the Cypress Docker images (factory/installScripts/yarn/default.sh) rely on the availability of a PGP signature file (.asc) and Yarn did not make this file available for any releases after v1.22.19 published two years ago.

If the Yarn team provides some response to the following two issues, then it should be easier to decide what to do with the Yarn v1 version in the Cypress Docker images:

  • https://github.com/yarnpkg/yarn/issues/9060
  • https://github.com/yarnpkg/yarn/issues/9035

Note that Yarn v1 Classic has been in maintenance mode since January 2020 (see https://classic.yarnpkg.com/en/docs/install) and there is no longer any focus on supporting this version, although an official end-of-life has not yet been declared.

MikeMcC399 avatar May 19 '24 09:05 MikeMcC399

Hi @MikeMcC399 ,

yeah, I saw that when I tried to push a PR on this. We are migrating from yarn v1 to sth else...so up to you if you want to close or keep open this issue.

vadimpopa avatar May 21 '24 08:05 vadimpopa

@vadimpopa

We are migrating from yarn v1 to sth else...so up to you if you want to close or keep open this issue.

I'm trying to get some clarity from through the Yarn v1 issues about what to expect from them, so I don't suggest closing this issue for the moment.

Migrating away from Yarn v1 Classic would be a good move for end-users in any case!

MikeMcC399 avatar May 21 '24 08:05 MikeMcC399

  • related discussion https://github.com/nodejs/docker-node/issues/2064

MikeMcC399 avatar May 24 '24 05:05 MikeMcC399

I've uploaded a GPG signature for Yarn v1.22.22, along with all other missing artifacts (.deb, .rpm, and Windows installer). This should be good to go now.

Daniel15 avatar May 24 '24 21:05 Daniel15

Thank you @Daniel15 !

MikeMcC399 avatar May 29 '24 11:05 MikeMcC399