cypress-chrome-recorder icon indicating copy to clipboard operation
cypress-chrome-recorder copied to clipboard

Add Support for Wait For Element Step

Open Who-Code opened this issue 1 year ago • 4 comments

Currently Wait For Element Steps from Chromes .json are not generated in the cypress test file.

This PR adds the basic functionality by generating .should('be.visible') including a timeout for the selector.

Who-Code avatar Feb 22 '24 11:02 Who-Code

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 22 '24 11:02 CLAassistant

cypress-app-bot avatar Feb 22 '24 11:02 cypress-app-bot

Any news on this?

@Who-Code first of all, thanks for adding it!. Then maybe you can clean your commits, because this project use yarn and there are already a yarn.lock file, that's means you can remove your package-lock.json, then there is console.log at line console.dir(step); 🙏🏽

And I do not know if you need to mark this PR as a Ready for Review

11joselu avatar May 08 '24 15:05 11joselu

@Who-Code Thanks for the contribution. I'll see if someone has time to look at this next sprint.

jennifer-shehane avatar May 08 '24 16:05 jennifer-shehane