circleci-orb icon indicating copy to clipboard operation
circleci-orb copied to clipboard

Failed start command in run job doesn't fail job

Open rbabayoff opened this issue 5 years ago • 1 comments

orb version: 1.26.0

The command after, waiton, "hangs" the job:

workflows: test: jobs: - cypress/install: executor: node-12 working_directory: packages/myapp1 build: cd packages/myapp1 && npm run build - cypress/run: executor: node-12 requires: - cypress/install attach-workspace: true working_directory: packages/myapp1 store_artifacts: true start: npm start wait-on: "http://localhost:3000"

rbabayoff avatar Oct 12 '20 22:10 rbabayoff

I was having this problem using react-scripts 3.4.3. I downgraded to react-scripts 3.4.0 and that solved the problem. I think react-scripts may have changed the output of the start command, and/or how it runs in the background in the more recent minor versions. UPDATE: Also tried upgrading to react-scripts 4.0.0 and that also solved the problem (much prefer this solution).

amymb avatar Oct 28 '20 20:10 amymb

Please try our new 3.0.0 version of our orb to see if this problem is still occurring. Closing as stale. Please open a new issue if you encounter something similar.

jennifer-shehane avatar Mar 01 '23 15:03 jennifer-shehane