circleci-orb icon indicating copy to clipboard operation
circleci-orb copied to clipboard

Normalize parameter names

Open bahmutov opened this issue 6 years ago • 2 comments

right now some parameters are using - and some _

Screen Shot 2019-07-11 at 10 43 12 AM

Unfortunately, this will be a breaking change, unless we keep both and deprecate ...

bahmutov avatar Jul 11 '19 14:07 bahmutov

https://github.com/cypress-io/circleci-orb/pull/238#issuecomment-597762926

Prefer - to _

Is this ready to be worked on, or are you trying to avoid breaking changes until some other feature?

kylemh avatar Mar 11 '20 17:03 kylemh

I would prefer to hold off. One big issue is that we don’t have full end to end testing to prevent accidental breaking changes

Sent from my iPhone

On Mar 11, 2020, at 13:41, Kyle Holmberg [email protected] wrote:

 #238 (comment)

Prefer - to _

Is this ready to be worked on, or are you trying to avoid breaking changes until some other feature?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bahmutov avatar Mar 11 '20 17:03 bahmutov

This is done in v3 of our Orb: https://github.com/cypress-io/circleci-orb/releases/tag/v3.0.0

jennifer-shehane avatar Feb 28 '23 17:02 jennifer-shehane