cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

feat/cyclops-ui: Add support to fetch Deployment/StatefulSet logs

Open Sheikh-Abubaker opened this issue 1 year ago • 12 comments

closes #257

📑 Description

Test video of Deployment/StatefulSet logs feature:

https://github.com/user-attachments/assets/643a6066-6c37-4b77-81fa-0e2ceb54e7ed

✅ Checks

  • [x] I have tested my code (provide screenshots or screen recordings of a working solution)
  • [x] I have performed a self-review of my code

ℹ Additional context

Reinstated the Handler functions for Deployment/StatefulSet logs i.e:

h.router.GET("/resources/deployments/:namespace/:deployment/:container/logs", modulesController.GetDeploymentLogs)
h.router.GET("/resources/statefulsets/:namespace/:name/:container/logs", modulesController.GetStatefulSetsLogs)

Tested the feature with both traditional API call using axios and the existing logstream function successfully.

Sheikh-Abubaker avatar Oct 28 '24 12:10 Sheikh-Abubaker

Hi @petar-cvit please check this out!

Sheikh-Abubaker avatar Oct 28 '24 12:10 Sheikh-Abubaker

@quest-bot loot #257

Sheikh-Abubaker avatar Oct 28 '24 20:10 Sheikh-Abubaker

Quest PR submitted! image Quest PR submitted!

@Sheikh-Abubaker, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

quest-bot[bot] avatar Oct 28 '24 20:10 quest-bot[bot]

Hey @petar-cvit, just updated the branch and it is now in sync with the main.

Sheikh-Abubaker avatar Nov 09 '24 18:11 Sheikh-Abubaker

@petar-cvit if you'd like to test the statefulset logs feature, you could utilise Grafana tempo chart: https://github.com/grafana/helm-charts/tree/main/charts/tempo/templates, and any template from the official Cyclops template repository: https://github.com/cyclops-ui/templates could be utilised to test deployment logs.

Sheikh-Abubaker avatar Nov 25 '24 14:11 Sheikh-Abubaker

Hey @petar-cvit tuned in the feature with the refactored code!

Sheikh-Abubaker avatar Dec 16 '24 23:12 Sheikh-Abubaker

Hey @petar-cvit looking forward to your review!

Sheikh-Abubaker avatar Jan 08 '25 15:01 Sheikh-Abubaker

@petar-cvit I'll address the changes in the coming weeks and let you know!

Sheikh-Abubaker avatar Jan 27 '25 14:01 Sheikh-Abubaker

Hey @petar-cvit I have refactored the code to create and reuse a single component which would fetch logs for K8s objects like Deployment or StatefulSets.

Sheikh-Abubaker avatar Feb 09 '25 20:02 Sheikh-Abubaker

@petar-cvit I have updated the branch and it is now in sync with main!

Sheikh-Abubaker avatar Feb 14 '25 16:02 Sheikh-Abubaker

Hey @petar-cvit just a gentle heads up, I haven't abandoned this PR, it's just that I'm having a limited bandwidth currently and will revert to working on it in the coming days, please don't close this PR 😀.

Sheikh-Abubaker avatar May 22 '25 10:05 Sheikh-Abubaker

noted 👍

petar-cvit avatar May 22 '25 10:05 petar-cvit