cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

Add tooltip to resource not needed warning

Open KaradzaJuraj opened this issue 1 year ago • 17 comments

Move the warning sign next to the resource name and status. Add a tooltip when hovering over the warning icon that displays “This resource is not used by the module anymore and can be deleted.”

To get the warning sign, you can use the demo template:

  1. deploy it with the service toggled on
  2. Edit the module and toggle the service off
  3. now you will have the warning sign on the service

KaradzaJuraj avatar Oct 21 '24 10:10 KaradzaJuraj

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #644 to link your PR to this Quest.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 21 '24 10:10 quest-bot[bot]

can you specify location?

"next"

image

ArnavK-09 avatar Oct 21 '24 15:10 ArnavK-09

@quest-bot embark

ArnavK-09 avatar Oct 21 '24 15:10 ArnavK-09

@ArnavK-09 has embarked on their Quest. 🗡

  • @ArnavK-09 has been on GitHub since 2020.
  • They have merged 126 public PRs in that time.
  • Their swords are blessed with TypeScript and CSS magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 21 '24 15:10 quest-bot[bot]

Move the warning sign next to the resource name and status.

and do i have to remove warning signs from here?

image

ArnavK-09 avatar Oct 21 '24 15:10 ArnavK-09

Hey @ArnavK-09, you currently already have two PRs open. Please finish those before starting new issues.

KaradzaJuraj avatar Oct 22 '24 11:10 KaradzaJuraj

can you review em

ArnavK-09 avatar Oct 23 '24 16:10 ArnavK-09

@quest-bot embark

AkashJana18 avatar Oct 30 '24 11:10 AkashJana18

@AkashJana18 has embarked on their Quest. 🗡

  • @AkashJana18 has been on GitHub since 2022.
  • They have merged 22 public PRs in that time.
  • Their swords are blessed with Shell and Dockerfile magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 30 '24 11:10 quest-bot[bot]

Hey @KaradzaJuraj,

I’m working on moving the warning sign next to the resource name and status, with a tooltip that displays “This resource is not used by the module anymore and can be deleted.” I’d appreciate a few clarifications to ensure it’s implemented accurately:

  1. Positioning of Warning Sign: Could you specify the exact placement of the warning icon relative to the resource name and status? For example, should it appear on the left, right, or directly adjacent to the status text?

  2. Tooltip Trigger: Should the tooltip appear when hovering over just the warning icon, or would you like it to also trigger when hovering over the resource name and status?

  3. Warning Sign Activation: After deploying the demo template with the service toggled on and then toggling it off, should the warning icon only appear when the module recognizes that the resource is unused, or immediately upon toggling off?

  4. Styling Preferences: Are there any specific styles or design elements for the warning icon that need to match other UI components, or should it follow the default warning icon style?

Thank you for the additional guidance!

AkashJana18 avatar Oct 30 '24 11:10 AkashJana18

Hey @AkashJana18

  1. To the right of the name and status
  2. Trigger only when hovering over the warning sign
  3. When the module recognizes that the resource is unused (but shouldn't matter in this issue)
  4. Use the same warning icon that is used now

I hope this clears things up; if you have any other questions - reach out!

KaradzaJuraj avatar Nov 06 '24 10:11 KaradzaJuraj

@quest-bot embark

krishnaagarwal781 avatar Dec 29 '24 07:12 krishnaagarwal781

@krishnaagarwal781 has embarked on their Quest. 🗡

  • @krishnaagarwal781 has been on GitHub since 2021.
  • They have merged 45 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

quest-bot[bot] avatar Dec 29 '24 07:12 quest-bot[bot]

Assign to me

Aryam2121 avatar Jan 15 '25 08:01 Aryam2121

@KaradzaJuraj can you please assign this to me, if still not resolved.

Wasiim105 avatar Feb 28 '25 06:02 Wasiim105

@Aryam2121 , what’s your status on this?

KaradzaJuraj avatar Mar 23 '25 19:03 KaradzaJuraj

Since @Aryam2121 didn't respond, @Wasiim105 are you still up to take this? Will assign you the issue in that case.

KaradzaJuraj avatar Mar 26 '25 09:03 KaradzaJuraj